-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
added code and content for frames #1915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👷 Deploy request for selenium-dev pending review.Visit the deploys page to approve it
|
PR Reviewer Guide 🔍
Resource Management
The WebDriver instance is not properly closed using try-with-resources or a finally block, which may lead to resource leaks.
Test Structure
The test method contains multiple assertions and operations, which violates the single responsibility principle for unit tests. Consider splitting into multiple test methods.
Hardcoded Wait
The use of implicitlyWait with a fixed duration may lead to unreliable tests. Consider using explicit waits for better test stability.
PR Code Suggestions ✨
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @pallavigitwork !
Thank you @harsha509 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks @pallavigitwork !
I see there are few tests failing looking into it!
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com> 7477ac9
Uh oh!
There was an error while loading. Please reload this page.
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
added content and code for frames example
Description
added content and code for frames example
Motivation and Context
added content and code for frames example as it wasn't there
Types of changes
Checklist
PR Type
enhancement, documentation
Description
FramesTestto demonstrate iframe interactions using Selenium.Changes walkthrough 📝
FramesTest.java
Add Java test for iframe interactions using Seleniumexamples/java/src/test/java/dev/selenium/interactions/FramesTest.java
FramesTestfor handling iframes.informationWithElementsto demonstrateswitching between iframes.
name, and index.
frames.en.md
Update English documentation with iframe example referenceswebsite_and_docs/content/documentation/webdriver/interactions/frames.en.md
frames.ja.md
Update Japanese documentation with iframe example referenceswebsite_and_docs/content/documentation/webdriver/interactions/frames.ja.md
iframes.
frames.pt-br.md
Update Portuguese documentation with iframe example referenceswebsite_and_docs/content/documentation/webdriver/interactions/frames.pt-br.md
iframes.
frames.zh-cn.md
Update Chinese documentation with iframe example referenceswebsite_and_docs/content/documentation/webdriver/interactions/frames.zh-cn.md
iframes.